Error with many domains #1

New Issue

Ghost · 2019-02-28T17:10:36Z

Ghost commented

2019-02-28 17:10:36 +00:00

I got this error when running greenlock.js. It seems like it only happens when registering many domains (somewhere around 20+), otherwise greenlock works fine. I use a pretty basic config with the http-01 challenge. All the domains are subdomains of the same organizational domain.

It does cause greenlock.register() to fail, but I believe the certs are actually being issued. It just never saves them config dir cache.

TypeError: Cannot read property 'children' of undefined
at E:\admin\nodejs\certs\node_modules\cert-info\lib\cert-info.js:79:39
at Array.map (<anonymous>)
at certInfo.info.certInfo.getBasicInfo (E:\admin\nodejs\certs\node_modules\cert-info\lib\cert-info.js:72:6)
at module.exports.attachCertInfo (E:\admin\nodejs\certs\node_modules\greenlock\lib\utils.js:14:18)
at process._tickCallback (internal/process/next_tick.js:68:7)

I got this error when running greenlock.js. It seems like it only happens when registering many domains (somewhere around 20+), otherwise greenlock works fine. I use a pretty basic config with the http-01 challenge. All the domains are subdomains of the same organizational domain. It does cause greenlock.register() to fail, but I believe the certs are actually being issued. It just never saves them config dir cache. TypeError: Cannot read property 'children' of undefined at E:\admin\nodejs\certs\node_modules\cert-info\lib\cert-info.js:79:39 at Array.map (<anonymous>) at certInfo.info.certInfo.getBasicInfo (E:\admin\nodejs\certs\node_modules\cert-info\lib\cert-info.js:72:6) at module.exports.attachCertInfo (E:\admin\nodejs\certs\node_modules\greenlock\lib\utils.js:14:18) at process._tickCallback (internal/process/next_tick.js:68:7)

coolaj86 commented

2019-02-28 17:17:35 +00:00

There should be a saved certificate in your ~/.acme directory.

Could you send me the public certificate so that I can run the parser on it and found out how it’s different?

If it failed before the save I can send you some patch code to apply and then get the saved cert.

There should be a saved certificate in your `~/.acme` directory. Could you send me the public certificate so that I can run the parser on it and found out how it’s different? If it failed before the save I can send you some patch code to apply and then get the saved cert.

Ghost commented

2019-03-01 14:07:38 +00:00

I'm in a windows environment and I'm not sure what you mean by ~/.acme directory. I checked the directory I have setup as my 'configDir' and I only saw the privatekey.pem.

I did jimmy with the code that threw the error and found that it did issue the cert, it just wouldn't save them if that file didn't work successfully. I tweaked it so the file wouldn't throw an error. It caused the altNames to not get pulled, but it did save the issued cert. I will send it to you.

I'm in a windows environment and I'm not sure what you mean by ~/.acme directory. I checked the directory I have setup as my 'configDir' and I only saw the privatekey.pem. I did jimmy with the code that threw the error and found that it did issue the cert, it just wouldn't save them if that file didn't work successfully. I tweaked it so the file wouldn't throw an error. It caused the altNames to not get pulled, but it did save the issued cert. I will send it to you.

Ghost commented

2019-03-01 18:17:43 +00:00

AJ very quickly found the fix.

In /lib/asn1-parser.js Ln 22 - change from 20 to 100