coolaj86/telebit.js
1
2
Fork 1
Code Issues 48 Pull Requests 3 Releases Activity

more descriptive wait message #33

Merged
coolaj86 merged 1 commits from clarify-waiting into master 2019-05-18 19:39:45 +00:00
Conversation 3 Commits 1 Files Changed 2 +2 -3
coolaj86 commented 2019-05-18 19:25:04 +00:00
Owner
Copy Link

Changed from waiting... to waiting for you to check your email

Changed from `waiting...` to `waiting for you to check your email`
ryanburnette approved these changes 2019-05-18 19:29:18 +00:00
ryanburnette left a comment
Collaborator
Copy Link

lgtm

lgtm
Ghost reviewed 2019-05-18 19:30:56 +00:00
bin/telebit-remote.js
@ -540,3 +540,3 @@
return;
}
console.info("waiting...");
console.info(TPLS.remote.waiting.replace(/{email}/, state.config.email));
Ghost commented 2019-05-18 19:29:16 +00:00
First-time contributor
Copy Link

Have we verified that this code has been run? Does TPLS ever change state/does TPLS.remote.waiting ever become unavailable if the state changes?

Have we verified that this code has been run? Does TPLS ever change state/does `TPLS.remote.waiting` ever become unavailable if the state changes?
Ghost commented 2019-05-18 19:33:24 +00:00
First-time contributor
Copy Link

Same with state.config.email ??? What about a decent fallback? What if the user doesn't enter an email??

Same with `state.config.email` ??? What about a decent fallback? What if the user doesn't enter an email??
coolaj86 commented 2019-05-18 19:34:30 +00:00
Author
Owner
Copy Link

TPLS is loaded only once, right at the start and it's values are static.

https://git.coolaj86.com/coolaj86/telebit.js/src/branch/master/lib/en-us.toml

https://git.coolaj86.com/coolaj86/telebit.js/src/branch/master/bin/telebit-remote.js#L15

TPLS is loaded only once, right at the start and it's values are static. https://git.coolaj86.com/coolaj86/telebit.js/src/branch/master/lib/en-us.toml https://git.coolaj86.com/coolaj86/telebit.js/src/branch/master/bin/telebit-remote.js#L15
Ghost commented 2019-05-18 19:38:26 +00:00
First-time contributor
Copy Link

Still not convinced that TPLS is assured as available, same with state.config. TPLS depends on valid loading of toml file. Still, am confident that error would throw before getting to this state/flow. Even if state.config.email is null, replace op would work, but would throw IF state.config is null.

Still not convinced that TPLS is assured as available, same with state.config. TPLS depends on valid loading of `toml` file. Still, am confident that error would throw before getting to this state/flow. Even if `state.config.email` is null, `replace` op would work, but would throw IF `state.config` is `null`.
coolaj86 commented 2019-05-18 19:38:38 +00:00
Author
Owner
Copy Link

The user must enter an email. Otherwise it'll loop back.

The user must enter an email. Otherwise it'll loop back.
Ghost commented 2019-05-18 19:39:05 +00:00
First-time contributor
Copy Link

But approving nonetheless as it is hard to verify the above for now. LGTM.

But approving nonetheless as it is hard to verify the above for now. LGTM.
Ghost approved these changes 2019-05-18 19:35:19 +00:00
coolaj86 closed this pull request 2019-05-18 19:39:45 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
ryanburnette
Ghost
Labels
Clear labels
feature
something new that would be great to add
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
josh ryanburnette coolaj86
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: coolaj86/telebit.js#33
No description provided.
Delete Branch "clarify-waiting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?